Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump async-upnp-client to 0.38.1 #108382

Merged
merged 2 commits into from
Jan 20, 2024
Merged

Bump async-upnp-client to 0.38.1 #108382

merged 2 commits into from
Jan 20, 2024

Conversation

StevenLooman
Copy link
Contributor

Proposed change

Bump async-upnp-client to 0.38.1. This contains StevenLooman/async_upnp_client#215, fixing an issue for some Samsung TVs where the returned DLNA data is incomplete.

Library changelog: https://github.com/StevenLooman/async_upnp_client/blob/development/CHANGES.rst#async_upnp_client-0381-2024-01-19
Library diff: StevenLooman/async_upnp_client@0.38.0...0.38.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @chishm, mind taking a look at this pull request as it has been labeled with an integration (dlna_dmr) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of dlna_dmr can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign dlna_dmr Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

Hey there @chishm, mind taking a look at this pull request as it has been labeled with an integration (dlna_dms) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of dlna_dms can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign dlna_dms Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

Hey there @chemelli74, @epenet, mind taking a look at this pull request as it has been labeled with an integration (samsungtv) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of samsungtv can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign samsungtv Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

Hey there @zewelor, @shenxn, @starkillerOG, @alexyao2015, mind taking a look at this pull request as it has been labeled with an integration (yeelight) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of yeelight can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign yeelight Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

bdraco
bdraco approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @StevenLooman

@StevenLooman
Copy link
Contributor Author

StevenLooman commented Jan 19, 2024 •
edited
Loading

You're welcome. I leave it up to you when to merge this.

I've set the milestone to the next patch release. If you believe this should not be added, feel free to change it.

@StevenLooman StevenLooman added this to the 2024.1.5 milestone Jan 19, 2024
@bdraco
Copy link
Member

bdraco commented Jan 20, 2024

test failure is unrelated

FAILED tests/components/fritz/test_update.py::test_update_available - AssertionError: assert 'unavailable' == 'on'

@bdraco bdraco merged commit 2b38973 into home-assistant:dev Jan 20, 2024
48 of 49 checks passed
frenck pushed a commit that referenced this pull request Jan 20, 2024
@StevenLooman @frenck
Bump async-upnp-client to 0.38.1 (#108382)
fb700cc
@frenck frenck mentioned this pull request Jan 20, 2024
Merged
@StevenLooman StevenLooman deleted the bump_async_upnp_client_0.38.1 branch January 21, 2024 10:18
nrdufour added a commit to nrdufour/home-ops that referenced this pull request Jan 21, 2024
@nrdufour
chore(deps): update ghcr.io/home-assistant/home-assistant docker tag …
02a3416 
…to v2024.1.5 (#324)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/home-assistant/home-assistant](https://www.home-assistant.io/) ([source](https://github.com/home-assistant/core)) | patch | `2024.1.4` -> `2024.1.5` |

---

### Release Notes

<details>
<summary>home-assistant/core (ghcr.io/home-assistant/home-assistant)</summary>

### [`v2024.1.5`](https://github.com/home-assistant/core/releases/tag/2024.1.5)

[Compare Source](home-assistant/core@2024.1.4...2024.1.5)

-   Bump async-upnp-client to 0.38.1 ([@&#8203;StevenLooman] - [#&#8203;108382]) ([upnp docs]) ([yeelight docs]) ([dlna_dmr docs]) ([samsungtv docs]) ([ssdp docs]) ([dlna_dms docs]) (dependency)
-   Fix empty files included by !include_dir_named ([@&#8203;emontnemery] - [#&#8203;108489])
-   Pin pandas to 2.1.4 ([@&#8203;frenck] - [#&#8203;108509])

[#&#8203;106970]: home-assistant/core#106970

[#&#8203;107239]: home-assistant/core#107239

[#&#8203;107365]: home-assistant/core#107365

[#&#8203;107883]: home-assistant/core#107883

[#&#8203;108379]: home-assistant/core#108379

[#&#8203;108382]: home-assistant/core#108382

[#&#8203;108489]: home-assistant/core#108489

[#&#8203;108509]: home-assistant/core#108509

[@&#8203;StevenLooman]: https://github.com/StevenLooman

[@&#8203;emontnemery]: https://github.com/emontnemery

[@&#8203;frenck]: https://github.com/frenck

[dlna_dmr docs]: https://www.home-assistant.io/integrations/dlna_dmr/

[dlna_dms docs]: https://www.home-assistant.io/integrations/dlna_dms/

[enigma2 docs]: https://www.home-assistant.io/integrations/enigma2/

[samsungtv docs]: https://www.home-assistant.io/integrations/samsungtv/

[shelly docs]: https://www.home-assistant.io/integrations/shelly/

[ssdp docs]: https://www.home-assistant.io/integrations/ssdp/

[streamlabswater docs]: https://www.home-assistant.io/integrations/streamlabswater/

[system_bridge docs]: https://www.home-assistant.io/integrations/system_bridge/

[upnp docs]: https://www.home-assistant.io/integrations/upnp/

[yeelight docs]: https://www.home-assistant.io/integrations/yeelight/

[zha docs]: https://www.home-assistant.io/integrations/zha/

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE0MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Reviewed-on: https://git.home/nrdufour/home-ops/pulls/324
Co-authored-by: Renovate <renovate@ptinem.io>
Co-committed-by: Renovate <renovate@ptinem.io>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

@starkillerOG starkillerOG Awaiting requested review from starkillerOG starkillerOG is a code owner

@chemelli74 chemelli74 Awaiting requested review from chemelli74 chemelli74 is a code owner

@epenet epenet Awaiting requested review from epenet epenet is a code owner

Assignees

@epenet epenet

@starkillerOG starkillerOG

@chemelli74 chemelli74

Labels
by-code-owner cherry-picked cla-signed core dependency integration: dlna_dmr integration: dlna_dms integration: samsungtv integration: ssdp integration: upnp integration: yeelight Quality Scale: internal Quality Scale: No score Quality Scale: platinum small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2024.1.5
Development

Successfully merging this pull request may close these issues.
6 participants
@StevenLooman @bdraco @frenck @epenet @starkillerOG @chemelli74